bcc-code / bmm-web

[BMM] The BMM website and desktop app to listen to the content from BMM.
https://bmm.bcc.media/
GNU Affero General Public License v3.0
16 stars 8 forks source link

Popup for Track details / More information #239

Closed kkuepper closed 7 months ago

kkuepper commented 10 months ago

240 also needs the popup component. Therefore it should be implemented as a separate PR that gets merged quickly.

Screenshot 2023-11-17 at 2 34 33 PM

SimonSimCity commented 9 months ago

Open questions:

Open improvements:

About references ... Maybe it's good to update the API to have a better typing here. There seems to be some kind of enum-type per relation of a track (https://github.com/bcc-code/bmm-api/blob/develop/BMM.Api.Core/DatabaseContract/RelationType.cs#L10) but its not typed, excepted for some typings I found (https://github.com/bcc-code/bmm-api/blob/develop/BMM.Api.Core/DatabaseContract/Track.cs#L216-L278). @kkuepper Would be good to know if its any good to improve the api here or whether at all its possible to prove that's even possible.

kkuepper commented 9 months ago

About locale: The current website uses "5. Jan 2024 - 14:26" which is the european version. I think it's fine to keep doing that. Do whatever is easy to do.

About references: I'm not sure what you want from me. It sounds like the typing doesn't work properly so we need to fix it. But you (@SimonSimCity) usually do that.

SimonSimCity commented 7 months ago

Fixed by https://github.com/bcc-code/bmm-api/pull/480, https://github.com/bcc-code/bmm-api/pull/485 and https://github.com/bcc-code/bmm-web/pull/301