bcc-code / bmm-web

[BMM] The BMM website and desktop app to listen to the content from BMM.
https://bmm.bcc.media/
GNU Affero General Public License v3.0
16 stars 8 forks source link

Settings Popups #240

Closed kkuepper closed 9 months ago

kkuepper commented 1 year ago

239 also needs the popup component. Therefore it should be implemented as a separate PR that gets merged quickly.

Screenshot 2023-11-17 at 2 38 35 PM

kkuepper commented 1 year ago

Would be nice if someone else can do the remaining 2 tasks

sifferhans commented 1 year ago

@kkuepper I can try fixing the last two tasks.

Another point: we should probably make the dialog component more accessible. We should constrain tabbing to inside the dialog when open to make it easier to navigate with a keyboard.

SimonSimCity commented 1 year ago

@sifferhans Feel free 😎 I've just done something because we needed something, but I wasn't putting a lot of effort into it.

sifferhans commented 1 year ago

@SimonSimCity I've created a draft PR where I change to using the Headless UI Dialog component as a base 😊 #256

sifferhans commented 1 year ago

@kkuepper Is the image you attached the way it should be designed? Both language settings in the same dialog?

kkuepper commented 1 year ago

@sifferhans The figma isn't exactly clear. I think Søren explored different ideas but didn't decide on one. My thought was to make separate dialogs, that each pretty much look like the in the image above. Do as feels natural to you and we might change it if Søren doesn't like it.

I think for now it's more important that we can change the content language, than how exactly it looks.