Closed kkuepper closed 9 months ago
Would be nice if someone else can do the remaining 2 tasks
@kkuepper I can try fixing the last two tasks.
Another point: we should probably make the dialog component more accessible. We should constrain tabbing to inside the dialog when open to make it easier to navigate with a keyboard.
@sifferhans Feel free 😎 I've just done something because we needed something, but I wasn't putting a lot of effort into it.
@SimonSimCity I've created a draft PR where I change to using the Headless UI Dialog component as a base 😊 #256
@kkuepper Is the image you attached the way it should be designed? Both language settings in the same dialog?
@sifferhans The figma isn't exactly clear. I think Søren explored different ideas but didn't decide on one. My thought was to make separate dialogs, that each pretty much look like the in the image above. Do as feels natural to you and we might change it if Søren doesn't like it.
I think for now it's more important that we can change the content language, than how exactly it looks.
239 also needs the popup component. Therefore it should be implemented as a separate PR that gets merged quickly.