Fix the way RSD is added to positions

bccp / nbodykit

Analysis kit for large-scale structure datasets, the massively parallel way

http://nbodykit.rtfd.io

GNU General Public License v3.0

111 stars 60 forks source link

Fix the way RSD is added to positions #645

Closed eelregit closed 3 years ago

eelregit commented 3 years ago

To address #644

eelregit commented 3 years ago

@rainwoodman

Could you change it to use dask?
Is there difference between creating a pull request using github web interface (surprised that I have the permission to make a new branch here) vs fork it to my repository first?

eelregit commented 3 years ago

CI got stuck because my non-dask code?

rainwoodman commented 3 years ago

This looks good to me. Shall we merge?

We shall make a release, then also update the examples at https://github.com/bccp/nbodykit-cookbook.

eelregit commented 3 years ago

I clicked merge and learned afterwards that the commits were not squashed. Sorry! How to fix that? Also changed a line in the cookbook.

eelregit commented 3 years ago

@rainwoodman Should I revert and then squash merge?

rainwoodman commented 3 years ago

No worries for this one -- but we shall see if github has an option to make squash the default..

On Tue, Oct 20, 2020 at 6:43 PM Yin Li notifications@github.com wrote:

@rainwoodman https://github.com/rainwoodman Should I revert and then squash merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bccp/nbodykit/pull/645#issuecomment-713237845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBWTDK76X6LE6JCKCXHD3SLY4CJANCNFSM4SRIGSEA .