search

bccsa / luminary

Offline-first content platform
Apache License 2.0
3 stars 2 forks source link

APP: Profile menu language selection #227

Closed belljohan3 closed 1 month ago

belljohan3 commented 1 month ago

What i have added in this PR.

Note that we need to read the language id from the LocalStorage and implment it the HomePage by taking into account the reactiveness.

belljohan3 commented 1 month ago

The tests that fails actually i something that we need to look at it. I have tried it before but it is not working. I mean the one on the HomePage

laurensgroeneveld commented 1 month ago

I left a comment but see it was added to the commit, so just leaving a link to it here for visibility: https://github.com/bccsa/luminary/commit/8a8c662ac9e604fb33a6e507227ae9dd6147b4db#r144422881

belljohan3 commented 1 month ago

Hey @laurensgroeneveld ! Not sure why you don't see changes but i have pushed. Check this commit. https://github.com/bccsa/luminary/pull/227/commits/91e11fad435757417572e05a1168ff4bc86ca3d2

belljohan3 commented 1 month ago

NOTE: i have skipped test in LanguageModal and ThemeSelector as the modal is not rendering properly because we use HeadlessUI/Modal.