clebreton
commented
2 years ago This is not new and why the quality_flags.fresh_inland_water exists. The reasoning was that these inland waters are indeed on land, but they needed the additional water classification. That’s why when you process water on land you use (!quality_flags.land || quality_flags.fresh_inland_water)
Kind regards, Carole
Carole Lebreton Brockmann Consult GmbH phone: +49 (0)40 69 63 89 - 314 email: @.*** skype-id: carole.lebreton.bc
Brockmann Consult GmbH Chrysanderstr. 1 D-21029 Hamburg, Germany Amtsgericht Hamburg HRB 157689 Geschäftsführer Dr. Carsten Brockmann Web: www.brockmann-consult.de Twitter: @BrockmannCon
From: Marco Peters @.> Sent: Mittwoch, 12. Januar 2022 13:57 To: bcdev/snap-idepix @.> Cc: Subscribed @.***> Subject: [bcdev/snap-idepix] Land flag follows different definition if SRTM option is enabled or disabled (Issue #57)
If the SRTM option is disabled, the quality_flags.land from the OLCI L1B is just passed to the pixel_classif_flags.IDEPIX_LAND flag. If the SRTM option is enabled, the pixel_classif_flags.IDEPIX_LAND is derived from the SRTM data.
This leads to the state that in the disabled-case inland water is marked as land and if SRTM is enabled it is not marked as land. See the attached image: [pixel_classif_OLCI-S3_SRTM_OnOff]https://user-images.githubusercontent.com/204590/149143450-9459de8a-c61a-4573-9c74-16869e1058b9.png On the left the data was processed without SRTM and on the right with SRTM.
For testing the product S3B_OL_1_ERR__20200107T065103_20200107T073500_20200108T102702_2637_034_120____LN1_O_NT_002.SEN3 has been used. The "missing" water area is the Caspian Sea.
It should be discussed how the definitions of the land flag can be harmonised and how we can handle this discrepancy.
— Reply to this email directly, view it on GitHubhttps://github.com/bcdev/snap-idepix/issues/57, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA5B7POWE5GB3O2X6O575YTUVV3ADANCNFSM5LY5AYLA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>
If the SRTM option is disabled, the quality_flags.land from the OLCI L1B is just passed to the pixel_classif_flags.IDEPIX_LAND flag. If the SRTM option is enabled, the pixel_classif_flags.IDEPIX_LAND is derived from the SRTM data.
This leads to the state that in the disabled-case inland water is marked as land and if SRTM is enabled it is not marked as land. See the attached image:
On the left the data was processed without SRTM and on the right with SRTM.
For testing the product S3B_OL_1_ERR__20200107T065103_20200107T073500_20200108T102702_2637_034_120____LN1_O_NT_002.SEN3 has been used. The "missing" water area is the Caspian Sea.
It should be discussed how the definitions of the land flag can be harmonised and how we can handle this discrepancy.