bcdice / bcdice-js

BCDice ported package for TypeScript and JavaScript by Opal.
BSD 3-Clause "New" or "Revised" License
22 stars 9 forks source link

Opalのバージョン上げ #40

Closed h-mikisato closed 2 years ago

h-mikisato commented 2 years ago

Opalの最新バージョンである1.3.2でコンパイルできるように修正しました。

修正箇所

一番目の件について、該当のパッチがない状態では以下のようにテストが失敗します


  1) ColossalHunter
       evals CH to (3CH) > 15[6,4,5] > 15:

      AssertionError: expected { '0': '(',
  '1': '3',
  '2': 'C',
  '3': 'H',
  '4': ')',
  '5': ' ',
  '6': '>',
  '7': ' ',
  '8': '1',
  '9': '5',
  '10': '[',
  '11': '6',
  '12': ',',
  '13': '4',
  '14': ',',
  '15': '5',
  '16': ']',
  '17': ' ',
  '18': '>',
  '19': ' ',
  '20': '1',
  '21': '5' } to equal '(3CH) > 15[6,4,5] > 15'
      + expected - actual

      -{
      -  "0": "("
      -  "1": "3"
      -  "2": "C"
      -  "3": "H"
      -  "4": ")"
      -  "5": " "
      -  "6": ">"
      -  "7": " "
      -  "8": "1"
      -  "9": "5"
      -  "10": "["
      -  "11": "6"
      -  "12": ","
      -  "13": "4"
      -  "14": ","
      -  "15": "5"
      -  "16": "]"
      -  "17": " "
      -  "18": ">"
      -  "19": " "
      -  "20": "1"
      -  "21": "5"
      -}
      +"(3CH) > 15[6,4,5] > 15"

      at /home/hmikisato/workspace/bcdice-js/ts/game_system_commands.test.ts:90:29
      at step (game_system_commands.test.ts:44:23)
      at Object.next (game_system_commands.test.ts:25:53)
      at fulfilled (game_system_commands.test.ts:16:58)

  2) ColossalHunter
       evals CH to (3CH) > 6[1,2,3] > 6:

      AssertionError: expected { '0': '(',
  '1': '3',
  '2': 'C',
  '3': 'H',
  '4': ')',
  '5': ' ',
  '6': '>',
  '7': ' ',
  '8': '6',
  '9': '[',
  '10': '1',
  '11': ',',
  '12': '2',
  '13': ',',
  '14': '3',
  '15': ']',
  '16': ' ',
  '17': '>',
  '18': ' ',
  '19': '6' } to equal '(3CH) > 6[1,2,3] > 6'
      + expected - actual

      -{
      -  "0": "("
      -  "1": "3"
      -  "2": "C"
      -  "3": "H"
      -  "4": ")"
      -  "5": " "
      -  "6": ">"
      -  "7": " "
      -  "8": "6"
      -  "9": "["
      -  "10": "1"
      -  "11": ","
      -  "12": "2"
      -  "13": ","
      -  "14": "3"
      -  "15": "]"
      -  "16": " "
      -  "17": ">"
      -  "18": " "
      -  "19": "6"
      -}
      +"(3CH) > 6[1,2,3] > 6"

      at /home/hmikisato/workspace/bcdice-js/ts/game_system_commands.test.ts:90:29
      at step (game_system_commands.test.ts:44:23)
      at Object.next (game_system_commands.test.ts:25:53)
      at fulfilled (game_system_commands.test.ts:16:58)```
esnya commented 2 years ago

👍🏻