search

bcedu / VGrive

Google Drive client for linux
GNU General Public License v3.0
313 stars 33 forks source link

Icon-Redesign #13

Closed Fatih20 closed 4 years ago

Fatih20 commented 4 years ago

The previous icon doesn't comply by the eOS HIG regarding outlines, contrast, shadows, and pictogram placement. Also, it doesn't look like an eOS-esque icon that has skeuomorphic but simplistic look.

bcedu commented 4 years ago

I want to change the icon, the current one was only temporal. But I would like the new one to be something like the folder icon from elementary (the icon of "files" app) with the google drive logo inside instead of the home logo.

What do you think?

Fatih20 commented 4 years ago

I think it's not a good idea to use the files icon from the original eOS icon set because they are built with different intention. Also, just slapping a google drive logo to an existing icon makes it look

  1. Cluttered, therefore hard to see in smaller sizes, doesn't comply by eOS HIG about visibility in all sizes.
  2. Amateur-ish
bcedu commented 4 years ago

I don't think it looks amateur if it's well done. Also, what can follow the elementary style guides more than the elementary files icon itself?

bcedu commented 4 years ago

I listen to new possible designts, but i dont really like the design that you have done in this PR

Fatih20 commented 4 years ago

Give me the reason why the current icon is bad? Because it's not literal? Icon is supposed to be a metaphor, this is not coding where you label every function as what EXACTLY it does.

Also, no, just copying the eOS icon doesn't suddenly make you icon eOS compliant, there are rules regarding the placement of pictogram since what you want to do is simply slapping a Gdrive icon on top of the files icon which, by the way, violated the 2 points out of 5 regarding Dos and Don'ts

Your icon should not be overly complicated. Keep in mind that since there are smaller sizes, the elements that make up your icon should be distinguishable when at those sizes. Avoid simply slapping an element onto a base shape; use a unique outline to make your icon more distinct. Have you actually downloaded your own apps from the appcenter and look how

  1. you need to squint your eyes to see what the apps icon represents in the application dropdown menu? I do this despite using a 24 inch QHD monitor.
  2. out of place it looked like if you put them next to other eOS icons?
bcedu commented 4 years ago

What i dont like about your new design is that it's hard to recognize that the app is related with google drive. It only has the colors but people usually dont know exatly the google drive colors. Also I dont like the cloud shape.

Fatih20 commented 4 years ago

Okay, do you have objective reasons why "cloud shape bad"? The eOS HIG specifies that design is not subjective.

And, again, the icon doesn't have to be literal. Anyone who has downloaded the apps has read what the app is for and so, doesn't need to be told what the app does every single time they open or search for the app. Just need to have a rough representation of it.

bcedu commented 4 years ago

I know that design is not only subjective, it has a goal. But I'm sure that there are other icons apart from this one that also acomplish the goal.

So, I'm just saying that I would like another design, that also acomplish the goal, different from this one (because I don't like it, and I think that the creator of the app has something to say about its icon).

And what I would like is an icon that shows in some way the logo from google drive.

Fatih20 commented 4 years ago

Alright, then. Let me change your mind on why putting a google drive logo on this app is a bad idea.

  1. Very thin but possible potential for Google to sue on the basis of copyright infringement
  2. You're essentially helping Google market its product by using the Gdrive logo, why would you want to be a free promoter of a product made by a multi-billion multi-national company?
  3. Your app doesn't feel distinct. It would feel like any other generic Gdrive client. By using a different logo, it would make your app, while still being a Gdrive client, a more distinct first impression by user who found it through something other than the appcenter.
bcedu commented 4 years ago

Mmh.. You are right with the copyright point.

What do you thinc about an icon formed by a folder icon and inside the folder with your logo (or some variation of it, as you like). I would like to mantain the idea of the fokder because the app acctually creats a folder and update the files of this folder

Fatih20 commented 4 years ago

It could be done.