search

bcg / em-mongo

EventMachine MongoDB Driver (based off of RMongo)
http://github.com/bcg/em-mongo
141 stars 47 forks source link

Is there any logging facility in em-mongo? #38

Closed jwarchol closed 12 years ago

jwarchol commented 12 years ago

I've briefly looked through the code and I'm not seeing any support for logging what em-mongo is doing. Has that been left out for a reason, or is it simply not implemented yet? I'm new to the project and am having a little trouble getting a feel for the history, design decisions and roadmap. Can any one comment on this question?

bcg commented 12 years ago

You mean like logging what it writes and reads from the server or just logging the methods invoked? Never really had a need for it unless I was really in the weeds getting spec to pass.

Not sure how to answer your questions about design decisions and roadmap. Any specifics?

jwarchol commented 12 years ago

Thanks for the quick reply @bcg! What I mean by logging is mostly query statement logging, especially during debugging. The ruby-mongo-driver has it, so I was confused when I couldn't find it for em-mongo, since compatibility was stated as a goal of the project. No worries, I just wanted to know if it was left off for some technical or philosophical reason, or if it's just waiting to be implemented. I'd specifically love to see connection IDs and response timings in logs.

As for design and roadmap, I mean how has the project evolved and where is it going. I see another issue asking about replica sets. Are they supported, unsupported, or unimplemented? I see myself using this project a great deal in my new work and I want to get involved in contributing to it.

bcg commented 12 years ago

Yea we try to mimic ruby-mongo-driver as much as we can. If you'd like to add logging you can submit a PR. As long as its conditional I don't see why we wouldn't merge.

I built em-mongo because I needed a bunch of the features at work. We are migrating off of mongo for some of our services so I personally don't need the features nor have time to develop them. There is no roadmap. If you want something added just go build it and I'll merge it. If you think I might not accept it ping me first and we can discuss. Thats how its worked in the past. This thread is probably best moved to email so I'm going to close.