search

bcgit / bc-csharp

BouncyCastle.NET Cryptography Library (Mirror)
https://www.bouncycastle.org/csharp
MIT License
1.67k stars 556 forks source link

What's up with 1.8.6 vs. 1.8.6.1? #236

Open j3parker opened 4 years ago

j3parker commented 4 years ago

We recently upgraded to the 1.8.6 package. 1.8.6.1 was published but there are no commits in git or release notes. I see that 1.8.6 was unlisted on nuget.org too.

What's up with 1.8.6.1?

I ran them both through ildasm and 1.8.6 had its assembly version set to 1.8.5 and 1.8.6.1 had it set to 1.8.6. There is a lot of other stuff going on in the diff but at least some of is just noise from non-deterministic builds. It might be nice to add <Deterministic>true</Deterministic> to the csproj files for this library so that it's easier to diagnose these things in the future :)

jstedfast commented 4 years ago

Presumably the reason for the 1.8.6.1 release was to fix the version number.