bcgit / bc-csharp

BouncyCastle.NET Cryptography Library (Mirror)
https://www.bouncycastle.org/csharp
MIT License
1.68k stars 558 forks source link

[BUG] unnecessary lock statements #564

Open zivillian opened 2 months ago

zivillian commented 2 months ago

Describe the Bug

I'm tracing my application for increased CPU usage after switching from openssl to bc-csharp and my profiler shows a lot of time is spent in AbstractTlsContext.get_SecurityParameters()

I'm not yet sure if this is the reason for the increased CPU usage in my application, but as far as I can tell the lock statement in all those properties will not do anything useful and may decrease the performance.

I'm happy to create a PR which removes the locks in this class, but I wanted to make sure, that I haven't missed anything.

Screenshots and Logs

grafik

Product Deployment

Please complete the following information: