Fix Register64 overflow on web platform

bcgit / pc-dart

Pointy Castle - Dart Derived Bouncy Castle APIs

MIT License

237 stars 122 forks source link

Fix Register64 overflow on web platform #130

Closed licy183 closed 3 years ago

licy183 commented 3 years ago

This PR fixes Register64.mul in src/ufixnum.dart, which possibly has wrong result.

This implementation uses 16-bit chunk as multiplication operand. The result produced is 32-bit chunk, and will not cause 52-bit overflow on web platform.

Fixes: #128

mwcw commented 3 years ago

Done thank you very much.