search

bcgit / pc-dart

Pointy Castle - Dart Derived Bouncy Castle APIs
MIT License
233 stars 122 forks source link

AES GCM now working in flutter web #181

Closed dani-weiss closed 1 year ago

dani-weiss commented 1 year ago

AES GCM used UInt64List which is not available on flutter web. This PR changes it to use UInt32List instead which should be sufficient for all practical purposes. This allows usage on flutter web.

See #178 and also this stackoverflow question for context.

redDwarf03 commented 1 year ago

Hello @mwcw, do you know if someone can validate this PR please ?

mwcw commented 1 year ago

Hi,

I don't have time to look at it, that may change next week.

MW

redDwarf03 commented 1 year ago

Thank you @mwcw . Are you alone to validate PR ?

redDwarf03 commented 1 year ago

Hello @mwcw. Sorry to contact you again. I don't necessarily want this PR to be validated right now (although I would like to) but I would need to know if possible when this is possible because it conditions a deployment on my side. Thx

redDwarf03 commented 1 year ago

i just tested this PR with my project and it works with flutter web

dghgit commented 1 year ago

Hi, so as I've mentioned elsewhere, it's become impossible for our current team to keep up with this in addition to what's going on in Java and C#. As such, we're looking for volunteers. Let me know if you're interested.

redDwarf03 commented 1 year ago

Hello @dghgit, what do you need to help you ? For example, i tested this PR with few updates and it worked without regressions.

andry-brill commented 1 year ago

👍 I tested this PR in my project, and everything worked fine (without this getting the same error). It's just two lines of code to fix, and that can make at least two people happier 😄

dani-weiss commented 1 year ago

For what it's worth, I'm using this pull request in a production app for about a month now.

redDwarf03 commented 1 year ago

And if this PR is merged, we have to find someone to publish on pub.dev too 🙏

dghgit commented 1 year ago

So getting merged and published would be a start. We've hit the wall as far as been able to provide time for this. If you're interest email me at dgh@bouncycastle.org I've had one expression of interest, but we really need a few people involved, I know from experience trying to manage something like this by yourself is the path to insanity.

redDwarf03 commented 1 year ago

Tests with web platform are ok and regression tests on other platforms (ios, android, macos, linux and windows) are ok too

redDwarf03 commented 1 year ago

https://github.com/bcgit/pc-dart/commit/e37a60085e60e036091ce782fd0187f56afe3a80

andry-brill commented 1 year ago

👍 Thanks, @redDwarf03 for the fix, and @Ephenodrom for 3.7.0 release! ❤️‍🔥