search

bcgit / pc-dart

Pointy Castle - Dart Derived Bouncy Castle APIs
MIT License
230 stars 120 forks source link

Incorrect api interface for PSSSigner #189

Closed giregk closed 1 year ago

giregk commented 1 year ago

I believe this PR should be merged: https://github.com/bcgit/pc-dart/pull/183

Indeed, the salt parameter is already included in a PSS signature output, so the code can find it by itself. The developer should not be required to deal with the salt manually.

Ephenodrom commented 1 year ago

The PR was merged, but I commited directly into the mirror git repository. With the latest pointycastle version it is now possible to verify a PSS signature with just the salt length.

If you still think there need to be some code changes, feel free to comment or open a new PR.

giregk commented 1 year ago

I must be missing something because I don't see the updated code in this repo and I don't see the pss_signer.dart file in the original repo.

Ephenodrom commented 1 year ago

@giregk Sorry that was my fault. I said that i commited the fix directly, but I didn't. Will release a new version next week with the fix.

giregk commented 1 year ago

@Ephenodrom amazing thank you !

Ephenodrom commented 1 year ago

Sorry that this took some time. Version 3.7.3 is now live on pub.dev including the fix.