search

bcgit / pc-dart

Pointy Castle - Dart Derived Bouncy Castle APIs
MIT License
237 stars 122 forks source link

Fix linters in ECC curves and signers #33

Closed Ephenodrom closed 4 years ago

Ephenodrom commented 4 years ago

I fixed several linter warnings in different classes.

Note : I marked the ECC curve classes with "// ignore: camel_casetypes", so that the linter will accept the class names using a "". Maybe we should change the class names later to camcel case writing, but I think this will affect other projects / packages that use this package.

Output of unit tests

pub run test 00:51 +361: All tests passed!

AKushWarrior commented 4 years ago

That would be a breaking change and should be reserved for a breaking version with more substantive updates; in other words, you're right about not changing class names for now.

The ignore thing is kind of an ugly workaround, but it still keeps those lints from registering in pub, so it's worth it as a temporary solution.

@mwcw this is merge-ready.

Ephenodrom commented 4 years ago

I also fixed the linter warnings in the "macs" folder.

mwcw commented 4 years ago

Hi,

This has been merged and will be synced shortly.

Once again thank you.

MW