bcgov / CONN-CCBC-portal

Intake for application process for Connected Communities BC funding program
Apache License 2.0
4 stars 3 forks source link

Validate Data types and MaxLength on Org profil & address #173

Closed MarsRomer-zz closed 2 years ago

MarsRomer-zz commented 2 years ago

As ISED I need to make sure that the character limits and data types are enforced so that my data import works with the schema I have in Salesforce

This ticket is limited to the forms that have already been created or will be created in the test environment during this sprint

Description

https://regexlib.com/REDetails.aspx?regexp_id=2790 https://owasp.org/www-community/OWASP_Validation_Regex_Repository

Acceptance Criteria

Organization Profile Page

band number

Org name

Is operating name same as legal name?

Operating name

Applicant organization a subsidiary?

Please enter the name of the parent organization

organization an Indigenous entity?

short description of the Indigenous entity

overview of the organization

Date of incorporation or registration

Applicant business number (9-digit business identifier provided by Canada Revenue Agency)

Organization Location Page Unit number

Street Number

Street name

PO Box

City

Province

Postal Code

Mailing address same?

Mailing address Same validations, errors, requirements as above

elliottSlee commented 2 years ago

Screen Shot 2022-06-08 at 12.21.29 PM.png

^(?!.*[DFIOQU])[A-VXY][0-9][A-Z]●?[0-9][A-Z][0-9]$

BryanGK commented 2 years ago

This card is complete - missing validations are being tracked in issue #217

MarsRomer-zz commented 2 years ago

@BryanGK @marcellmueller When I click on Band Council or Other radio buttons on the Org profile page, I don't get the text box where I can put in the band number or describe my organization. I am pretty sure that I saw that working last week.

MarsRomer-zz commented 2 years ago

@marcellmueller @BryanGK Are the changes in the test environment? I am testing the PO box and it allows characters and doesn't limit to 9 characters

MarsRomer-zz commented 2 years ago

@marcellmueller @BryanGK Is the province supposed to give me a dropdown list to choose from? I am not getting that, which is fine for now but I noticed it was checked off in your checklist

MarsRomer-zz commented 2 years ago

@marcellmueller @BryanGK The organization location page is showing the address fields as 'Optional'. Can we please remove that word from the titles?

BryanGK commented 2 years ago

@MarsRomer it would appear that when the form pages were split out in separate files my updated pages were not properly copied over. I'll get that fixed ASAP.