Closed rajpalc7 closed 1 year ago
This ticket is completed now, moved to review/qa on 23rd August
Waiting for @rajpalc7 to create a PR containing the rocket.chat integration script updates and link it to this issue.
https://github.com/bcgov/platform-services-sre/pull/20 - A new PR has been created
@rajpalc7, please see Shelly's and my comments on the PR.
Hi Wade, I thought shelly's comments were addressed when I was showing the demo yesterday.
@rajpalc7, If you look at the diff here; https://github.com/bcgov/platform-services-sre/pull/20/files
You'll see there are still some outstanding whitespace issues to address:
Such as extra spaces here:
Missing spaces here:
and, seemingly a combination of extra/missing spaces or tabs here:
Fixed the formatting now
Complete
The scripts for the uptime notification are not working as expected, They don't seem to support days and exact time . If any service is down for more than a day, it will just show as the service was just down for some hours.
Please look into fixing the scripting part of the uptime notification and make sure it shows that service was down for days, time and hours.