bcgov / DITP-DevOps

Digital Identity and Trust Program Team's DevOps Documentation Repository
Apache License 2.0
2 stars 5 forks source link

The scripts for the uptime notification are not working as expected #94

Closed rajpalc7 closed 1 year ago

rajpalc7 commented 1 year ago

The scripts for the uptime notification are not working as expected, They don't seem to support days and exact time . If any service is down for more than a day, it will just show as the service was just down for some hours.

Please look into fixing the scripting part of the uptime notification and make sure it shows that service was down for days, time and hours.

rajpalc7 commented 1 year ago

This ticket is completed now, moved to review/qa on 23rd August

WadeBarnes commented 1 year ago

Waiting for @rajpalc7 to create a PR containing the rocket.chat integration script updates and link it to this issue.

rajpalc7 commented 1 year ago

https://github.com/bcgov/platform-services-sre/pull/20 - A new PR has been created

WadeBarnes commented 1 year ago

@rajpalc7, please see Shelly's and my comments on the PR.

rajpalc7 commented 1 year ago

Hi Wade, I thought shelly's comments were addressed when I was showing the demo yesterday.

WadeBarnes commented 1 year ago

@rajpalc7, If you look at the diff here; https://github.com/bcgov/platform-services-sre/pull/20/files

You'll see there are still some outstanding whitespace issues to address: image

Such as extra spaces here: image

Missing spaces here: image

and, seemingly a combination of extra/missing spaces or tabs here:

image

rajpalc7 commented 1 year ago

Fixed the formatting now

rajpalc7 commented 1 year ago

https://github.com/bcgov/platform-services-sre/compare/main...rajpalc7:platform-services-sre:main - this should do it

WadeBarnes commented 1 year ago

Complete