search

bcgov / EDUC-EAS-API

Apache License 2.0
0 stars 0 forks source link

Draft scripts commit for OCP deployment #1

Closed sumathi-thirumani closed 4 weeks ago

sumathi-thirumani commented 4 weeks ago

Includes the scripts for listed:

Review comments:

  1. Remove the property "EDX_API_URL" - Completed
  2. Upgrade the java version on pom.xml - Completed
  3. Switch to Postgres from oracle (pom.xml) - Completed a. Rename the props from "ORACLE_USERNAME", "ORACLE_PASSWORD" to "JDBC_USERNAME" and "JDBC_PASSWORD". b. Change the dialect. Current value = org.hibernate.dialect.PostgreSQLDialect
  4. Fix "Secret Name" in deployment template - Completed
  5. Remove the listed props from updateConfig.sh - Completed a. KEYCLOAK_PUBLIC_KEY b. TOKEN_URL c. SCHEDULED_JOBS_EXTRACT_UNCOMPLETED_SAGAS_CRON d. SCHEDULED_JOBS_EXTRACT_UNCOMPLETED_SAGAS_CRON_LOCK_AT_LEAST_FOR e. SCHEDULED_JOBS_EXTRACT_UNCOMPLETED_SAGAS_CRON_LOCK_AT_MOST_FOR f. SAGAS_MAX_PENDING g. SAGAS_MAX_PARALLEL
  6. Fix the issue for NOT NULL in updateConfig.sh Change Details below. - Fixed & Validated. a. Add check to extract secret only if clientID is not null and empty b. Instead of !="" leverage -n