search

bcgov / EDUC-GRAD-TRAX-API

TRAX Read Write API for GRAD team
Apache License 2.0
0 stars 0 forks source link

Created messaging subscribers for Institute contact events #325

Closed cditcher closed 4 months ago

cditcher commented 4 months ago

For ticket: https://eccbc.atlassian.net/browse/GRAD2-2644

arybakov-cgi commented 4 months ago

Hi @cditcher , please address the maintainability issues in the code.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cditcher commented 4 months ago

There remains one issue but with the inheritance chain, changing to contstructor injection forces child classes to implement same. It will have to remain field injection.