search

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Metadata Standard.
Other
6 stars 0 forks source link

Create UI for reviewing published revisions without making an edit #379

Closed NicoledeGreef closed 4 months ago

NicoledeGreef commented 4 months ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6216011879

On the Build page, if a record is up for Review there is no obvious way for a an editor to approve the review without making an actual edit to expose the publishing dialog.

lkmorlan commented 4 months ago

What would you like it to do? When there have been no edits since the published version, there is the message "Latest revision is published." We could have it so that the box with this message has a button to record that a full review has been done and no edits are needed, perhaps "Full review completed; no changes needed". That is a bit long. It could have the "This is a full review" checkbox and the button read "Update" instead of "Publish" (if you click "Update" without checking the checkbox, nothing changes). Other ideas?

NicoledeGreef commented 4 months ago

We'll go with (2). The update button is disabled until they check the box "This is a full review."

lkmorlan commented 4 months ago

This is implemented on dv14. We can hide the "Update" button but we can't disable it because of this Drupal core bug:

https://www.drupal.org/project/drupal/issues/3354998

NicoledeGreef commented 4 months ago

reviewed on dv14