search

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Metadata Standard.
Other
6 stars 0 forks source link

Modifications to the display of the IM schedule #392

Closed CraigClark closed 3 months ago

CraigClark commented 3 months ago

OP timer

Layout

Change the layout of the label/value. Labels should all align left and the values should all have the same left alignment. Similar to how tab stops would look in a word processor document.

Once that is done, test removing the bold font weight. This is to comply with gestalt contrast design principals. We are replacing weight for proximity to differentiate labels and values.

Originally this was a discussion about labels

original discussion about labels ## Label changes ### Node view change > Information schedule type: value > IM cassification code: value > Business category: value to > IM schedule type: value > IM classification code: value > IM business category: value ### Information schedule term page change > Information schedule type: value > Information schedule name: value > Business function: value > Business category: value > IM classification code: value to > IM schedule type: value > IM schedule name: value > IM Business function: value > IM Business category: value > IM classification code: value
CraigClark commented 3 months ago

This comes from #391

@mjmcclung, does this accurately reflect what was discussed?

@NicoledeGreef , I would like your thoughts on this before we proceed.

mjmcclung commented 3 months ago

Yes, you've summarized it correctly. While all the 'IM' prefixes may seem redundant, it adds significant value in terms of clarity and context given our organizations maturity in this space. Having these, and having this consistency, will make the education and awareness piece much easier, so thank you for accommodating this.

Should we add requirements to adjust the layout/bold font weight for the second piece of the Information schedule term page as well, for consistency? image

CraigClark commented 3 months ago

Should we add requirements to adjust the layout/bold font weight for the second piece of the Information schedule term page as well, for consistency?

Nah, that goes without saying. Just didn't document it.

NicoledeGreef commented 3 months ago

The redundancy of "IM" is not great. It makes it challenging to read and takes the eye away from what really matters...the words after IM. Would be much better to express "IM" or "Information Management" in the header and leave it at that.

In general, shorter descriptions are better, as are non-repeated labels.

mjmcclung commented 3 months ago

Not sure where to go from here - should we just leave it as-is then?

Classification code must be prefixed by 'IM' until our maturity improves. I deal with this point of confusion regularly (weekly/monthly) and have no desire to perpetuate this confusion in this space as well.

CraigClark commented 3 months ago

Let's leave the labels alone. I can change the label/value layout of term page easy enough, It would make it look more modern. Are you ok with that @NicoledeGreef ?

NicoledeGreef commented 3 months ago

Sure, let's try that. Can you please mock something up, @CraigClark ?

CraigClark commented 3 months ago

@NicoledeGreef sure

CraigClark commented 3 months ago

@lkmorlan ready fore review/merge https://github.com/bcgov/MFIN-Data-Catalogue/tree/392-update-info-schedule-term-page-layout

CraigClark commented 3 months ago

@NicoledeGreef to approve

NicoledeGreef commented 3 months ago

@mjmcclung - please review in Test

For example: https://test.cat.data.fin.gov.bc.ca/node/46

Image

https://test.cat.data.fin.gov.bc.ca/information-schedule/orcs/property-taxation/property-taxation-general/general

Image

mjmcclung commented 3 months ago

Is it possible to have a larger gap between the IM classification code and Active period on the term page to help differentiate these two sections? There was a large gap before, but with the changes it seems to have gone away. Having a larger gap will help users differentiate that these are separate chunks of information, rather than overwhelming them with everything all at once.

image

CraigClark commented 3 months ago

@mjmcclung yes, we can do that

CraigClark commented 3 months ago

@mjmcclung Useless trivia.

Drupal programmatically assigns every piece of content a unique ID (called a node id) that cannot be changed.

Amusing coincidence in the node IDs:

CraigClark commented 3 months ago

@mjmcclung I've added the spacing fix task here #410 , If you are happy with this ticket other than that, could you please close it?

NicoledeGreef commented 3 months ago

Closing #392; outstanding styling change is in #410