search

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Administrative and Descriptive etadata Standard.
Other
6 stars 0 forks source link

Remove use of private use Unicode character for search icon #393

Closed lkmorlan closed 6 months ago

lkmorlan commented 6 months ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6304210320

Describe the bug

The value attribute of the search button is a Unicode Private Use Area character to display the search symbol. This causes an HTML validation warning.

To reproduce

Validate any page with the search box.

Expected behaviour

Add the character using CSS.

CraigClark commented 6 months ago

@lkmorlan

ready for review/merge

there are two branches to fix this

  1. https://github.com/bcgov/bcbb/tree/dc-393-replace-unicode-icon-in-search-submit
  2. https://github.com/bcgov/bcbb-theme/tree/dc-393-theme-icon-in-search-submit
lkmorlan commented 6 months ago

Merged