Style fixes | keep this open

CraigClark commented 3 months ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6381923925

This task will stay open. It's for small changes we need to make to the theme. These changes aren't big enough to need their own issue, but they're still important to keep track of.

[x] Increase spacing between items on the data dictionary paragraph edit form. see #409
[x] more space below logo on header so logo is horizontally centred
[x] Additional space above active period on info schedule term page as per #392
[x] Add margin to top of footer for readability
[x] Move devel styles to proper style sheets
[x] Decrease spacing between page title and underline
[x] fix inconsistent font weight on field labels on build pages form view
[x] add space above sidebar on mobile
[x] ensure consistency across the reports - done as part of #441
[x] make the manage page use the same exposed filter style as the report builder
[x] on dashboard, move search bar to the header and make the manage records look decent
[x] make sure all booleans are explicit yes/no and display inline (pending @NicoledeGreef approval)
[x] ~~Fix sidebar on book pages that touch the side of the screen on mobile~~
[x] in the build pages, source system has too much space between the label and the input field

CraigClark commented 3 months ago

@lkmorlan Please review/merge:

[x] Data catalogue spacing styles https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-spacing-issues
[x] base theme spacing adjustments https://github.com/bcgov/bcbb-theme/tree/410-dc-spacing-issues

lkmorlan commented 3 months ago

Merged

CraigClark commented 2 months ago

@lkmorlan please review/merge

[x] Data catalogue changes https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-move-devel-styles-to-theme
[x] Base theme changes https://github.com/bcgov/bcbb-theme/tree/410-dc-move-devel-styles-to-theme

lkmorlan commented 2 months ago

Merged

CraigClark commented 2 months ago

inconsistent labels fixed with this commit on this branch

CraigClark commented 2 months ago

Search box moved to header and display of manage records on dashboard fixed with this commit

CraigClark commented 2 months ago

@NicoledeGreef I'm thinking booleans would be better as radios. It is more explicit than a checkbox. It would require an editor to choose between yes and no.

instead of

We would have

This would make it work the same way as Personal information, the only other boolean currently in use.

Do you approve this change?

CraigClark commented 2 months ago

Manage records page has same design as report pages with this commit

It wound be nice at some point to format the sort choices as radios. There is no option for this in UI, it would require custom code.

lkmorlan commented 2 months ago

Merged

CraigClark commented 1 month ago

Booleans made explicit with this branch https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-booleans-to-explicit-yes-no @lkmorlan to review/merge

CraigClark commented 1 month ago

Sidebar nav touching side of screen on mobile is no longer an issue. A while ago I remove a bootstrap gap glass that was wrapping the entire container, that may have fixed it.

CraigClark commented 1 month ago

Space added above sidebar on mobile fixed in this branch https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-fix-spacing-on-side-bar @lkmorlan please review/merge.

lkmorlan commented 1 month ago

Merged

CraigClark commented 1 month ago

[x] Appearance of series field fixed by this branch https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-series-field

@lkmorlan please review/merge

lkmorlan commented 1 month ago

Merged

CraigClark commented 1 month ago

Closing this. All documented adjustments are done and there is no time left in the project for additional changes.

bcgov / MFIN-Data-Catalogue

Style fixes | keep this open #410