search

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Administrative and Descriptive etadata Standard.
Other
6 stars 0 forks source link

Assess and remove duplicate "Source system" taxonomy #458

Closed NicoledeGreef closed 5 months ago

NicoledeGreef commented 5 months ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6552899330

It was determined that the best thing to do is remove source_system vocabulary.

~- [x] ensure the field source system is using the correct Source system taxonomy~ ~- [x] resolves any errors that result from switching the taxonomy associated with Source system~ ~- [x] check any Views where the old taxonomy is being used and swap/remove it applicable~ ~- [x] check search facets to ensure the correct taxonomy is being used~ ~- [x] update source_system taxonomy with new values that have been added to data_system~

~## Deployment steps~

~1. - [ ] export all Test and Prod records using the report builder, this is to get the current source_system values, note the values~ ~2. - [ ] delete existing source_system values on prod~ ~3. - [ ] delete vocabulary data_system on dv14, dev, test and prod. This has been relabelled to DELETE | source system~ ~4. - [ ] deploy~ ~5. - [ ] once deployment is complete, manually update the records to match the values @NicoledeGreef~

CraigClark commented 5 months ago

In tests, we need to find records that use the source system, delete the value, then we can add it back after config is done

In ddev I tried using the content overview vbo to set source_system to none, it didn't work. Noting here, I'll try in dv14

CraigClark commented 5 months ago

New issue created from this task #459

CraigClark commented 5 months ago

For search facts, I'm seeing a facet called blob. I believe this is happening because there are values in the source_system field that are not in the taxonomy. This problem shouldn't occur if we empty out the values currently used by Source system .

Resolved. This was an issue with an orphaned term. IT has been resolved on dv14 and prod

CraigClark commented 5 months ago

@lkmorlan

Ready for review/merge https://github.com/bcgov/MFIN-Data-Catalogue/tree/458-remove-duplicate-source-system-taxonomy

before we can import the config, we need to delete the vocabulary data_system

CraigClark commented 5 months ago

@NicoledeGreef before we commit this, I would like to confirm that source_system is the vocabulary you want to keep and not data_system.

@lkmorlan recalls a discussion where we were going to go with data_system because that's what the term represents. Then we could reuse it elsewhere. So think if it like "The source system for this data is this data system", where field_source_system on the metadata record gets populated by values from the data_system vocabulary. Then in the future, data_system is available for other things and it's easy to understand because data_system is just a list, sources or not.

Please let me know what taxonomy you want to keep.

If you want to use source_system we will deploy this change. The work is done.

If you want to keep data_sysyem, it's even easier since field_source_system already uses it, all we need to do is delete source_system and re-label data_system for clarity.

NicoledeGreef commented 5 months ago

if the underlying name data_system is the one to keep let's do that and keep the Source system and Source system docs.

CraigClark commented 5 months ago

@lkmorlan ready for review/merge https://github.com/bcgov/MFIN-Data-Catalogue/tree/458-remove-source-system-vocab-and-update-data-system

lkmorlan commented 5 months ago

Merged. The terms in source_system need to be removed before deployment.