"Unpublish" button is displayed to Manager when a record is already unpublished?

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Administrative and Descriptive etadata Standard.

Other

6 stars 0 forks source link

"Unpublish" button is displayed to Manager when a record is already unpublished? #465

Closed NicoledeGreef closed 6 months ago

NicoledeGreef commented 6 months ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6578633388

Describe the bug

Metadata management screen, logged in as a Manager. The presence of the "Unpublish" button seems contradictory.

Other records have different combos of buttons based on the conditions of the user (did they author the MR? what Org membership does the user have? Is the MR published?)

Should "Draft" moderation state have the Unpublish button?

CraigClark commented 6 months ago

Agree. It can be confusing to users to see a button to do a thing that's done already. If you do try to unpublish an unpublished record it will give you an error message, which is good, but best would be if the button wasn't there at all

NicoledeGreef commented 6 months ago

verified in dev