ampersand displaying as & in the charts on Metadata Metrics report

[NicoledeGreef]

Visit the Metadata metrics report screen.

[danhgov]

I found the bug, in the Charts module. I created an issue on their issue queue ([HTML encodings (e.g. "\&") showing up in legend]), figured out where the fix was needed, and submitted an Merge Request in the issue for it to be pulled into the Charts module.

I've also added the patch from that MR into the composer.json for the DataCat, so that we can be using that patch already.

(While working on this, I saw that @lkmorlan also submitted issues for this same module, and was the last person to update the file that I updated. Small world.)

It's working on my localhost. Still need to push it up to github, and deploy it to dev.

[danhgov]

This was deployed in PR https://github.com/bcgov/MFIN-Data-Catalogue/pull/513

It is working on dev.

[danhgov]

I just realised that I had patched our code yesterday by linking to the merge-request I had made on Drupal.org for my patch to the Charts module. That does work, but the merge-request can be updated by other people, which could result in code we haven't tested ending up on our production server.

So I just added a simple patch file to a comment on the same issue, and linked to that as our patch. This change is in this PR: https://github.com/bcgov/MFIN-Data-Catalogue/pull/514

[danhgov]

@NicoledeGreef, this fix is deployed to Dev and Test, where it appears to me to be working.

Example URLS:

• https://dev.cat.data.fin.gov.bc.ca/user/136/reports
• https://test.cat.data.fin.gov.bc.ca/user/138/reports

[NicoledeGreef]

Reviewed in Test; checked pie chart label, Visibility, and Office of Primary Responsibility as they all tie into Organization. All good.

[chrislaick]

Deployed to PROD.