search

bcgov / MFIN-Data-Catalogue

The Finance Data Catalogue enables users to discover data holdings at the BC Ministry of Finance and offers information and functionality that benefits consumers of data for business purposes. The product is built using Drupal and adheres to the Government of BC's Core Administrative and Descriptive etadata Standard.
Other
6 stars 0 forks source link

I am not receiving emails for major changes to MRs I bookmarked #559

Closed david-fong-bc closed 1 month ago

david-fong-bc commented 1 month ago

Describe the bug

I don't receive emails for major changes to MRs I bookmarked. I can reproduce this in the dev environment, and I have not tried in the test or production environments yet. This happens both for MRs that I created, and for ones I did not create.

I am logged in to the dev environment with my IDIR, "DAFONG", with email address david dot fong at gov dot bc dot ca (written weirdly here to hide from spam crawlers).

To reproduce

Steps to reproduce the behaviour (for example):

  1. Both Nicole and I bookmarked https://dev.cat.data.fin.gov.bc.ca/april-19-test, which is a MR she created with her IDIR account.
  2. I edited it and published with major changes. Nicole got an email, but I did not (I refreshed outlook, checked my junk folder and did an inbox search, and didn't see it).
  3. I made another edit and published with major changes again, and Nicole got an email, but I did not.

Nicole and I also tried with a MR I created, and a revision published by her, and I also didn't get an email for it. That was with https://dev.cat.data.fin.gov.bc.ca/node/156/revisions.

Expected behaviour

I expected to get emails about published revisions for MRs I bookmark.

Additional context

Here's a screenshot Nicole took from gcnotify that shows that emails were sent to her, but not to me:

image

david-fong-bc commented 1 month ago

@danhgov Can you take a look at this? We're wondering if it's just due to some intentional configuration for the dev and test environments. I can also reproduce in the test environment.

danhgov commented 1 month ago

Hi @david-fong-bc,

This is happening because on Dev & Test, the notification service (GC Notify) has been configured in "Test mode", which means that emails are not actually sent to people, unless they are on this safe-list:

@NicoledeGreef, I have just added David so that he can be part of testing, and removed all of the Openplus people (including Will Hearn) since their contract has been over for a few months now.

david-fong-bc commented 1 month ago

@danhgov Thanks for the info and the change! I just tested in the dev environment and I receive notification emails now.