bcgov / MOH-PPPP-Enrolment

Apache License 2.0
1 stars 0 forks source link

Feat: CSR validation #120

Closed stephanieharrison-maximus closed 3 years ago

stephanieharrison-maximus commented 3 years ago

Please check if the PR fulfills these requirements:

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

--All fields except the Plan Reference Number are optional in the CSR form for both Pay Patient and Pay Practitioner --To elaborate: they have been made Not Required in their validators, and any additional validations have been set to optional (eg. they only apply if there is input in the field) --Added end-to-end tests to check that optional fields are, indeed, optional in the CSR version --Fixes bug in ReviewTableList where empty store input would cause a reference error --Puts API Service call in an if block so it only runs if not CSR --It only flags a validation error for isContainingNoChargeFeeItem if not CSR path --Changes some validators to account for CSR status (hospitalVisitDateValidator + Past Validator and FutureValidator)

Additional Notes:

Refers to CLMWEBDE-84