Please check if the PR fulfills these requirements:
[X] After these changes, the app was run and still works as expected
[ ] Tests for these changes were added (if applicable) this was NOT done, as I never completed unit testing for the MainForm for either pay patient or pay prac. My goal is to create these tests before the phase 2 deployment goes out, but it'll be easier to do the testing all at once before the deploy-phase-2 branch merges into main. However, the validators.js tests were updated slightly as they already exist.
[X] All existing unit tests were run and still pass
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
--add new ValidateIf function to assist with validations
--make changes to clarificationCodeValidator in helpers
--change implementation of diagnosticCode validations. now checks if value is alphanumeric in all cases, and only runs diagnosticCodeValidator if route is not CSR.
--change test implementation for clarificationCodeValidator given the structural changes made to it
Additional Notes:
The implementation of the clarificationCodeValidator is a little different from the diagnosticCodeValidator one, even though they both accomplish the same thing. Given the time constraints on the project as a whole, I'm not sure it'd be efficient to change the clarificationCode validations to match the diagnosticCode ones, but I can do so if the benefits in maintainability outweigh the time costs.
Please check if the PR fulfills these requirements:
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
--add new ValidateIf function to assist with validations --make changes to clarificationCodeValidator in helpers --change implementation of diagnosticCode validations. now checks if value is alphanumeric in all cases, and only runs diagnosticCodeValidator if route is not CSR. --change test implementation for clarificationCodeValidator given the structural changes made to it
Additional Notes:
The implementation of the clarificationCodeValidator is a little different from the diagnosticCodeValidator one, even though they both accomplish the same thing. Given the time constraints on the project as a whole, I'm not sure it'd be efficient to change the clarificationCode validations to match the diagnosticCode ones, but I can do so if the benefits in maintainability outweigh the time costs.