bcgov / MyGovBC-CAPTCHA-Widget

An angularjs 2-4 component for displaying the CAPTCHA to the user and calling the service for validation
Apache License 2.0
1 stars 2 forks source link

DEMCL-22: Improve accessibility (WIP) #7

Closed bryce-mcmath closed 3 years ago

bryce-mcmath commented 4 years ago

What I did: 1) Changed attributes and tags for accessibility 2) Tested with axe, axe-beta (Deque), and NVDM screen reader 3) Restyled, removing inline styles, unnecessary tags. and most floats / clears

Previous Axe Results

axe_results_before

New Axe Results

axe_results_after

Old Captcha

old_captcha

New Captcha (same behavior on Chrome, Edge, IE11, Firefox)

captcha

bryce-mcmath commented 4 years ago

We can also restyle the buttons to look like default anchor tags again, or leave them as default styled buttons, or add new styles altogether

samuel-amos commented 4 years ago

The replacement of the links with buttons does make a change from how the previous captcha looks. I would add Ernesto as a reviewer to this PR so that someone on the UI team can approve the new look as this will update other forms besides DEAM.