search

bcgov / NRPTI

Natural Resources Public Transparency Initiative
Apache License 2.0
5 stars 14 forks source link

Migration to fix issuing agencies #1044

Closed RFK250 closed 1 year ago

RFK250 commented 1 year ago

FOR DISCUSSION WITH KYLE. May require a research ticket to understand where the data needs to be changed. Refer to https://github.com/bcgov/NRPTI/blob/master/api/migrations/20210712174600-mergeIssuingAgencyNames.jsfor similar changes (from 2021).

Description: When government ministries undergo reorganizations and/or name changes, migrations must be run to update Issuing Agency values in Nrpti records.

Currently, there are multiple variations of Issuing Agency values that must be addressed. See image below.

Conversion should be as follows:

Agricultural Land Commission -> No change Agriculture Land Commission -> Agricultural Land Commission BC Oil and Gas Commission -> BC Energy Regulator (There is already a separate ticket for this change) BC Parks -> No change BC Wildfire Service -> No change Climate Action Secretariat -> No change Conservation Officer Service -> No change Environmental Assessment Office -> No change Environmental Protection Division -> Ministry of Environment and Climate Change Strategy FLNRO -> Ministry of Forests Ministry of Agriculture Food and Fisheries -> Ministry of Agriculture and Food Ministry of Agriculture and Food -> No change Ministry of Energy Mines and Low Carbon Innovation -> No change Ministry of Environment and Climate Change Strategy -> No change Ministry of Forests -> No change Ministry of Forests Lands Natural Resource Operations and Rural Development -> Ministry of Forests Natural Resource Officers -> No change

image.png

Priority: If these records are not updated, then incorrect and/or outdated issuing agency values will be displayed to NRPTI and NRCED users. The optics of this are poor as it looks unprofessional. Additionally, it could potentially impact a user doing analysis on NRPTI data or on a NRCED CSV output.

Additional Context (use acceptance criteria format)

  1. Database migration to update outdated names
  2. Have importers run and see if any are changed back to the outdated names
RFK250 commented 1 year ago

@jakemorr FYI I did an analysis of the data, and it does not appear that any of the NRPTI importers or the NRPTI UI are still producing these incorrect values (except for the BC Oil and Gas Commission importer, per the other ticket). Simple migrations should be all that's needed here - essentially just a "Find and Replace" exercise.