bcgov / NRPTI

Natural Resources Public Transparency Initiative

Apache License 2.0

5 stars 15 forks source link

[TECH-DEBT][NRPTI-1167]** add additional testing for CORE integration #1174

Closed davidclaveau closed 9 months ago

davidclaveau commented 9 months ago

Pull Request Standards

[x] The title of the PR is accurate
[x] The title includes the type of change [HOTFIX, FEATURE, etc]
[x] The PR title includes the ticket number in format of [NRPTI-###]
[x] Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

Add additional testing for the CORE integration (and CORE-documents)

File	Old Coverage	New Coverage	Improvement
integrations/core (all files)	37.74%	63.21%	+25.47%
--base-record-utils.js	81.82%	87.88%	+6.06%
--collection-utils.js	20.83%	91.67%	+70.84%
--datasource.js	31.66%	44.72%	+13.06%
--mine-utils.js	66.67%	96.97%	+30.3%
--permit-utils.js	10.34%	100%	+89.66%
integrations/core-documents (all files)	48.65%	72.3%	+23.65%
--base-record-utils.js	85.71%	85.71%	-
--datasource.js	31.07%	65.05%	+33.98%
--permit-utils.js	100%	100%	-
Average Improvement	-	-	~40.65%

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication