bcgov / NRPTI

Natural Resources Public Transparency Initiative

Apache License 2.0

5 stars 15 forks source link

[TECH-DEBT][NRPTI-1167]** add additional testing for NRIS integrations #1177

Closed davidclaveau closed 9 months ago

davidclaveau commented 9 months ago

Pull Request Standards

[x] The title of the PR is accurate
[x] The title includes the type of change [HOTFIX, FEATURE, etc]
[x] The PR title includes the ticket number in format of [NRPTI-###]
[x] Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

add additional testing to datasource.js for nris-emli integration
add testing to datasource.js for nris-epd integration
add fake environmental variables for Jest to use for additional testing

File	Old Coverage	New Coverage	Improvement
integrations/nris-emli	28.9%	81.19%	+52.29%
--datasource	28.9%	81.19%	+52.29%
integrations/nris-epd	27.05%	78.69%	+51.64%
--datasource	27.05%	78.69%	+51.64%
Average Improvement	-	-	~51.9%

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication