bcgov / NRPTI

Natural Resources Public Transparency Initiative
Apache License 2.0
5 stars 15 forks source link

Feat/[NRPTI-1194] - Move hardcoded Acts and Regulations to DB #1196

Closed sanjaytkbabu closed 5 months ago

sanjaytkbabu commented 6 months ago

Pull Request Standards

Description

This PR includes the following proposed change(s):

Issue NOT addressed: If the Energy Resource Activity Act were updated next month, the app would automatically reflect this change. In the front end, filters and options would show the new value. For records, all records that get added/updated through the daily cronjob and by using the IMPORT buttons will have their values automatically updated. BUT other records associated with this act that were added from other sources like through the "add record" feature will not be updated. Then, if searching for records and filtering by the new act, these records will not appear.

Future work should modify all existing records to replace their legislation with constant codes that map to the appropriate value. This value is then what gets updated. This way, records themselves will not need to be updated. The front end will translate the codes based on their mapped association. Implementing this feature in this ticket would have ballooned an already too large task.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud