bcgov / NRPTI

Natural Resources Public Transparency Initiative
Apache License 2.0
5 stars 15 forks source link

[FIX][NRPTI-1239] Amp record redaction fix (temporary workaround) #1259

Closed acatchpole closed 1 month ago

acatchpole commented 1 month ago

Pull Request Standards

Description

When deciding if a record needs redaction, one of the checks is of the issuing agency and making sure that it has authority to publish records. BUT due to the change to using an intermediate code for representing agencies, this check was often comparing the actual agency name to the agency code and authorized agencies were not getting through. The first version of the fix included an async function that required many other upstream functions to be converted to async. Ultimately, this task was not able to be successfully completed in a timely manner. A bandaid function was created using hardcoded values. These will eventually be out of date and the bug behaviour will start appearing again. #1258 was created to address this tech debt.

This PR includes the following proposed change(s):

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud