[x] The title includes the type of change [HOTFIX, FEATURE, etc]
[x] The PR title includes the ticket number in format of [NRPTI-###]
[x] Documentation is updated to reflect change
Description
When deciding if a record needs redaction, one of the checks is of the issuing agency and making sure that it has authority to publish records. BUT due to the change to using an intermediate code for representing agencies, this check was often comparing the actual agency name to the agency code and authorized agencies were not getting through. The first version of the fix included an async function that required many other upstream functions to be converted to async. Ultimately, this task was not able to be successfully completed in a timely manner. A bandaid function was created using hardcoded values. These will eventually be out of date and the bug behaviour will start appearing again. #1258 was created to address this tech debt.
This PR includes the following proposed change(s):
updated the check to see if the issuing agency has authority to publish by translating the agencyName to the associated agencyCode
Pull Request Standards
HOTFIX
,FEATURE
,etc
][NRPTI-###]
Description
When deciding if a record needs redaction, one of the checks is of the issuing agency and making sure that it has authority to publish records. BUT due to the change to using an intermediate code for representing agencies, this check was often comparing the actual agency name to the agency code and authorized agencies were not getting through. The first version of the fix included an async function that required many other upstream functions to be converted to async. Ultimately, this task was not able to be successfully completed in a timely manner. A bandaid function was created using hardcoded values. These will eventually be out of date and the bug behaviour will start appearing again. #1258 was created to address this tech debt.
This PR includes the following proposed change(s):