PIMS-1603 Column Filtering Fixes - Githubissues

bcgov / PIMS

Property Inventory Management System

https://pims.gov.bc.ca

Apache License 2.0

47 stars 43 forks source link

PIMS-1603 Column Filtering Fixes #2456

Closed dbarkowsky closed 3 months ago

dbarkowsky commented 3 months ago

## 🎯 Summary [PIMS-1603](https://citz-imb.atlassian.net/browse/PIMS-1603?atlOrigin=eyJpIjoiZTQzNDgwNTBlOThmNDNhY2EwYjkwYzE1MDI3OWEzMjYiLCJwIjoiaiJ9)

PO testing showed that the fix for searching the Parent Agency column on the Agencies table was missed.

Changes

Using valueGetter instead of valueFormatter on columns that need to be searched by their visible value, not their underlying value.
Making 'date' type columns out of columns that were just showing the dates as strings. This allows for filtering those columns using the datepicker tool.

🔰 Checklist

[x] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

I have performed a self-review of my code.

I have commented my code, particularly in hard-to-understand areas.

I have made corresponding changes to the documentation where required.

I have tested my changes to the best of my ability.

My changes generate no new warnings.

github-actions[bot] commented 3 months ago

🚀 Deployment Information

The React APP Image has been built with the tag: 2456. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.