search

bcgov / PIMS

Property Inventory Management System
https://pims.gov.bc.ca
Apache License 2.0
42 stars 43 forks source link

PIMS-1771: Parcel building union view #2461

Closed GrahamS-Quartech closed 1 month ago

GrahamS-Quartech commented 1 month ago
## 🎯 Summary [PIMS-1771](https://apps.itsm.gov.bc.ca/jira/browse/PIMS-1771) Just adding a new view so that we can more easily display the parcels and buildings in the same table on the front end. Mostly to facilitate the server side pagination ticket, since it's not really possible to sort and paginate effectively unless we are performing that action on a single table (view). ## 🔰 Checklist - [x] I have read and agree with the following checklist and am following the guidelines in our [Code of Conduct](CODE_OF_CONDUCT.md) document. > - I have performed a self-review of my code. > - I have commented my code, particularly in hard-to-understand areas. > - I have made corresponding changes to the documentation where required. > - I have tested my changes to the best of my ability. > - My changes generate no new warnings.
codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit e2ba9433 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.4%.

View more on Code Climate.

github-actions[bot] commented 1 month ago

🚀 Deployment Information

The Express API Image has been built with the tag: 2461. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

GrahamS-Quartech commented 1 month ago

Should we add lot size to this for Parcels? It's used in the inventory table.

True, didn't notice this before, I will add it. Also, I welcome suggestions for better naming for this view/entity, couldn't think of anything more appropriate.

LawrenceLau2020 commented 1 month ago

Should we add lot size to this for Parcels? It's used in the inventory table.

True, didn't notice this before, I will add it. Also, I welcome suggestions for better naming for this view/entity, couldn't think of anything more appropriate.

Could this be called a property_list view?

GrahamS-Quartech commented 1 month ago

Could this be called a property_list view?

I think it sounds too "plural". Other tables are named as a singular. PropertyUnion feels like it has this problem a bit too but it's a bit more ambiguous at least.