search

bcgov / PIMS

Property Inventory Management System
https://pims.gov.bc.ca
Apache License 2.0
42 stars 43 forks source link

PIMS-1774 and PIMS-1757 #2462

Closed LawrenceLau2020 closed 1 month ago

LawrenceLau2020 commented 1 month ago
## 🎯 Summary [PIMS-1774: ](https://citz-imb.atlassian.net/browse/PIMS-1774) - Make exemption requested field not required [PIMS-1757: ](https://citz-imb.atlassian.net/browse/PIMS-1757) - New Disposal Project Submitted notification email not being sent

PIMS-1757 - Altered the project_status_notification seed from "6" to NULL for the from_status_id column on templates 1 & 2. The project status id of 6, which is "Review" isn't really used in the new PIMS.

PIMS-1774 - Altered the migration which seeded the "Exemption Requested" task from StatusId of 4 to 8 for "Submitted Exemption".

Creating a new project should trigger a "New Disposal Project Submitted" notification to be sent. This should also happen on ERP exempted projects.

🔰 Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.
codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 4218bf55 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.4%.

View more on Code Climate.

GrahamS-Quartech commented 1 month ago

If I submit a project and request the exception, it doesn't actually complete the task that says exemption was requested. I think there's a disconnect somewhere with how the add project checkbox gets assigned to this task value.

This was because the exemption field left on the frontend was the old metadata version. I've pushed a fix to ensure it maps to the task instead.