bcgov / PIMS

Property Inventory Management System
https://pims.gov.bc.ca
Apache License 2.0
42 stars 43 forks source link

PIMS-1801 Replace Joins with Lookup #2472

Closed dbarkowsky closed 3 weeks ago

dbarkowsky commented 4 weeks ago
## 🎯 Summary [PIMS-1801](https://citz-imb.atlassian.net/browse/PIMS-1801)

Reducing the need for database joins by using the lookup context instead.

Changes

Issues

Didn't remove the joins on get__ services. This mostly just applies to tables. Replacing the joins on these tables with just the Id value affects the server-side pagination addition in a negative way. Can continue to look for a solution, but would like to see how the pagination is applied to the Disposal Inventory table first.

Testing

Just use the app as normal. Note if any values appear missing or if any errors are thrown.

🔰 Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.
codeclimate[bot] commented 4 weeks ago

Code Climate has analyzed commit d5d1cf4d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.4%.

View more on Code Climate.