Closed dbarkowsky closed 3 weeks ago
Code Climate has analyzed commit d5d1cf4d and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 93.4%.
View more on Code Climate.
Reducing the need for database joins by using the lookup context instead.
Changes
Issues
Didn't remove the joins on get__ services. This mostly just applies to tables. Replacing the joins on these tables with just the Id value affects the server-side pagination addition in a negative way. Can continue to look for a solution, but would like to see how the pagination is applied to the Disposal Inventory table first.
Testing
Just use the app as normal. Note if any values appear missing or if any errors are thrown.
🔰 Checklist