Closed LawrenceLau2020 closed 2 weeks ago
🚀 Deployment Information
The Express API Image has been built with the tag: 2486
. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.
Code Climate has analyzed commit 07b97249 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 80.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 93.2%.
View more on Code Climate.
Changes
Adding restrictions on property search in projects so that "General Users" should only be able to add their own agency's properties, while administrators can add a property from any agency to a project.
Only properties that are in "Surplus Active" or "Surplus Encumbered" classification can be added.
I needed to change the propertiesFuzzySearch, so hoping this doesn't break anything.
Testing
To test, you'll need to change your user's role to a "General User", then search for a property and confirm that you can only see properties belonging to your agency and if you belong to a parent agency, that properties belonging to the sub agency also can be added.
These properties should all have a classification of either "Surplus Active" or "Surplus Encumbered".
🔰 Checklist
[x] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.