PIMS-1821: Fixing agency filtering on properties and projects

LawrenceLau2020 commented 3 weeks ago

## 🎯 Summary [PIMS-1821: ](https://citz-imb.atlassian.net/browse/PIMS-1821)

Changes

Moved getProjects to use querybuilder instead of .find. Needed to get both AND and OR nested WHERE options.

Issues

Status isn't seen as a valid alias for filtering. Works for sorting though, but trying to filter on any field created by a join seems to crash it.
- It's not clear what it wants for the Status alias.
- Would it be easier to just make a view for this table? Then no joins in query.
Preset filters (from the dropdown) not working as expected, especially when setting it to the all option.
Using column filter with quicksearch filter overwrites the first filter. This makes it possible to search for records that should be omitted based on the other filter.

🔰 Checklist

[ ] I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

I have performed a self-review of my code.

I have commented my code, particularly in hard-to-understand areas.

I have made corresponding changes to the documentation where required.

I have tested my changes to the best of my ability.

My changes generate no new warnings.

github-actions[bot] commented 3 weeks ago

🚀 Deployment Information

The Express API Image has been built with the tag: 2488. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 55c4ae0b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.2%.

View more on Code Climate.

TaylorFries commented 2 weeks ago

I can add both filters and the results match. Issue: It seems like I can continue paging through non results? Like I can just keep clicking to the next page forever. Also the number of results always says "of more than x" where x is the upper limit of results on that page. Screenshot 2024-07-05 at 8 27 51 AM EDIT: found the ticket that was created to fix this, marking this comment as outdated.

bcgov / PIMS