search

bcgov / PIMS

Property Inventory Management System
https://pims.gov.bc.ca
Apache License 2.0
42 stars 43 forks source link

PIMS-1851 Submit Button Spacing #2500

Closed dbarkowsky closed 2 weeks ago

dbarkowsky commented 2 weeks ago
## 🎯 Summary [PIMS-1851](https://citz-imb.atlassian.net/browse/PIMS-1851)

Changes

Tried to do this in the base layout at first, but there is some weird interaction with how the main component uses 100vh. This was simpler, but will have to be done for any future pages like this.

🔰 Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.
github-actions[bot] commented 2 weeks ago

🚀 Deployment Information

The React APP Image has been built with the tag: 2500. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

GrahamS-Quartech commented 2 weeks ago

I made some changes to this so that you don't need to add padding to every page where this occurs. It should behave more consistently between browsers too. Also noticed that Chrome adds these extra unnecessary scrollbars to the DataTable, so I removed the overflow prop to make them go away.