bcgov / PIMS

Property Inventory Management System
https://pims.gov.bc.ca
Apache License 2.0
42 stars 43 forks source link

PIMS-1828: PID Formatting on Map Filter #2504

Closed TaylorFries closed 1 week ago

TaylorFries commented 2 weeks ago
## 🎯 Summary [PIMS-1828: ](https://citz-imb.atlassian.net/browse/PIMS-1828)

Added isPid bool to the textFormField so that when a user uses the filter by pid it gets formatted as a pid

🔰 Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.
github-actions[bot] commented 2 weeks ago

🚀 Deployment Information

The React APP Image has been built with the tag: 2504. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

TaylorFries commented 1 week ago

The formatting looks good, and the filter works! Just a minor issue, if you mistyped say the first 3 digits of the PID, eg. 123-456-789 and tried to change just the first 3 digits to 321 it doesn't seem to work, but highlighting the entire PID and then retyping the correct PID "321-456-789" works.

I will create a ticket in the backlog to maybe look into how this pidformatting works and if we want to update it.