bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 14 forks source link

Finastra Part-time File Review Changes #1934

Closed andrewsignori-aot closed 1 year ago

andrewsignori-aot commented 1 year ago

Compilation of bugs and changes needed after Finastra part-time file tests.

e-Cert tuition remittance

The system is saving to the column disbursement_schedules.tuition_remittance_effective_amount when it should actually be saving the minimum value between tuition_remittance_requested_amount and max calculated tuition remittance. Source code reference: e-cert-generation.service.ts

File name change

The name of the file that SIMS generates needs to be different than the one generated by SFAS. Waiting for Finastra to provide us with the file names.

File max line length

The total line length for the header, record, and footer must be adjusted to be 756. image.png

Field of study

The "field of study" should be sent as a text but it is currently being sent as a number. So, considering the field of study as 32, it should be sent as "32 " instead of "0032".

Grants

The e-Cert generation is trying to find a grant named CSGPT but the workflow is actually generating the grant as CSPT and also the position of the grants is not correct.

Feedback file

Acceptance Criteria

andrepestana-aot commented 1 year ago

As we didn't have the requirements for "The file name change" item atm, it was transferred to https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2479