bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
24 stars 13 forks source link

Incorporate Parental Voluntary Contributions #2267

Open HRAGANBC opened 1 year ago

HRAGANBC commented 1 year ago

Description of Task Revise the Full-Time workflow calculations and Form.IO variable names to ensure Parental Voluntary Contributions handled consistent with policy.

Context

Current Behaviour Voluntary contribution is submitted in the Parent Tab/Support Portal and combined under calculatedDataParentalContribution. Then in Step 10, calculatedDataParentalContribution is assigned to (calculatedDataParentalWeeklyContribution / calculatedDataTotalParentEligibleContributionDependants * offeringWeeks) which is then used to determine calculatedDataParentalContribution. Private Zenhub Image Private Zenhub Image

calculatedDataTotalParentalContribution = max(calculatedDataParentalContribution + calculatedDataParentalAssetContribution, calculatedDataParentalContribution)

Expected Behaviour Voluntary contribution is submitted in the Parent Tab/Support Portal and combined under calculatedDataParentalVoluntaryContribution, using a different name to prevent confusion with values. In Step 10, calculatedDataParentalContribution can now stay the same as it is functioning correctly for that part. In calculatedDataTotalParentalContribution the new voluntary variable can be used as the second value in the max comparison: calculatedDataTotalParentalContribution = max(calculatedDataParentalContribution + calculatedDataParentalAssetContribution, calculatedDataParentalVoluntaryContribution)

Acceptance Criteria

CarlyCotton commented 10 months ago

@HRAGANBC @Joshua-Lakusta I've updated the ticket with my analysis of voluntary parental contribution. Please take a look - I believe it is straightforward and is backed by the MASS calculator.

Joshua-Lakusta commented 10 months ago

I see all the analysis regarding step 10 but is it also being used correctly in 8c? For a dependent student your analysis and info is correct as above because the Parental voluntary is excluded in 8c for dependent students. However, for independent students this is calculated along with public and private funds as a part of Step 8C.

CarlyCotton commented 10 months ago

@Joshua-Lakusta There is a step in the process where the amount entered as voluntary parent contributions (from the Financial Tab) is addressed and added to calculatedDataTargeted if the student is independant, not considered at all if dependant: Private Zenhub Image calculatedDataTargetedResources (if independant) = studentDataGovernmentFundingCosts + studentDataNongovernmentFundingCosts + studentDataParentVoluntaryContributionsCosts

`calculatedDataTargetedResources (if dependant) = studentDataGovernmentFundingCosts + studentDataNongovernmentFundingCosts