bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 13 forks source link

Designation Request - Role Validation #2742

Closed CarlyCotton closed 2 months ago

CarlyCotton commented 8 months ago

User Story As a non-BC Public institution user (legal signing authority), when I submit a designation request I should be submitting two different people for the Eligibility Officer and Enrolment Officer Roles. If I am not submitting two different people, I want to be advised to send an email to the ministry to prevent delays in my designation.

Acceptance Criteria

Business Context

image.png
CarlyCotton commented 8 months ago

Best Case: Validation between two role Option: Better messaging re same people in the role as it's against policy and needs to be reviewed (email to designat)

guru-aot commented 3 months ago

@CarlyCotton when the match for the Eligibility Officer and Enrolment Officer are considered, do we need to take into account their names ONLY? or do we consider their email id OR AND phone number? If the banner is shown as a warning while submitting the designation request, the user will not see the banner in the same screen, so it would be better when they are trying to add the details in the table. Can we show this banner as the names match while typing in the text boxes?

CarlyCotton commented 3 months ago

@guru-aot

when the match for the Eligibility Officer and Enrolment Officer are considered, do we need to take into account their names ONLY? or do we consider their email id OR AND phone number?

Just Name, we can ignore email and phone number (possible they might use a generic email / office number)

If the banner is shown as a warning while submitting the designation request, the user will not see the banner in the same screen, so it would be better when they are trying to add the details in the table.

Banner underneath the table, no pop-up or additional messaging when they submit their Designation Request.

Can we show this banner as the names match while typing in the text boxes?

I would expect no banner show before anything is typed in the fields (they are the "same" since both blank) If the user types the same name into the second name field and then changes focus out of the name box, that is ideally when the banner would show. Then it would show until they have updated either of the fields to be different and changes focus out of the name box again.

Are there limitations in doing that?

sh16011993 commented 2 months ago

@CarlyCotton need to check regarding any limitation in doing this (I believe it will be tricky since this is a formio component and we plan on showing the banner inside this formio component but other devs can confirm) but I have two additional questions. Just to confirm the below: 1) Since it is a warning banner, we are allowing the submission of the form even if both the names are same and the warning banner is showing, correct? 2) You have mentioned that the warning banner shows up when the user starts typing in the 2nd field and if the names become the same and there is a change in focus from the component, we show the warning. Likewise will be true for the reverse scenario, correct? since the user is free to type in any of the boxes, they can type in first in the 2nd box and then type in the first box and we mimic the same behavior, correct?

CarlyCotton commented 2 months ago

@sh16011993

  1. Correct, it should still allow the user to submit the designation request with the warning banner showing.
  2. Yes, should work both ways. I am also open to other creative solutions with a similar effect given formio limitations.
sh16011993 commented 2 months ago

Thanks @CarlyCotton

dheepak-aot commented 2 months ago

@CarlyCotton both eligibility officers and enrolment officers can be one to many people. (Technically array of names) Hence, are we suppose to match 2 separate list of names e.g. eligibility officers (name1,name2) vs enrolment officers (name1, name2).

Or should we assume that there will be only one eligibility and one enrolment officer and not more than that(even though system accepts) and validate the first item in both lists ??

CarlyCotton commented 2 months ago

@dheepak-aot

We can't assume that there will only be one of each role entered. There are a lot of BC Privates that have multiple locations so may enter multiple people under each role. Can we compare the two separate list of names?