bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 14 forks source link

#3260 - CAS Integration 3A - Create new Supplier and Site - Process in Parallel #3837

Closed andrewsignori-aot closed 4 weeks ago

andrewsignori-aot commented 4 weeks ago
andrepestana-aot commented 4 weeks ago
  • Adjusted supplier's processes to happen in parallel.
  • Reduced the amount of allowed parallel processes to 2 to 4.

" Increased the amount of allowed parallel processes from 2 to 4."

andrewsignori-aot commented 4 weeks ago
  • Adjusted supplier's processes to happen in parallel.
  • Reduced the amount of allowed parallel processes to 2 to 4.

" Increased the amount of allowed parallel processes from 2 to 4."

My comment was not clear, I meant that the default value was decreased from the "os.cores" amount (potentially 32 on Openshift) to 2 or 4 😉 I edited the PR description to be clear.

dheepak-aot commented 4 weeks ago

Thank you very much for making the change. minor comments and a question.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 weeks ago

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.58% ( 3667 / 16243 )
Methods: 10.19% ( 206 / 2022 )
Lines: 25.96% ( 3183 / 12260 )
Branches: 14.18% ( 278 / 1961 )
github-actions[bot] commented 4 weeks ago

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )
github-actions[bot] commented 4 weeks ago

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.87% ( 1175 / 1401 )
Methods: 84.29% ( 118 / 140 )
Lines: 84.78% ( 997 / 1176 )
Branches: 70.59% ( 60 / 85 )
github-actions[bot] commented 4 weeks ago

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )