bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 14 forks source link

#3729 - CAS Integration 3B - Create New Site (Supplier found, Multiple Sites / No matching address) #3884

Closed lewischen-aot closed 1 week ago

lewischen-aot commented 2 weeks ago
dheepak-aot commented 2 weeks ago

Nice work. Please take a look at the comments.

dheepak-aot commented 2 weeks ago

Thanks for making the changes. Added more comments. Please have a look.

I tested the create site CAS API as well.

image

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

github-actions[bot] commented 1 week ago

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.3% ( 3709 / 16630 )
Methods: 10.38% ( 214 / 2061 )
Lines: 25.65% ( 3217 / 12544 )
Branches: 13.73% ( 278 / 2025 )
github-actions[bot] commented 1 week ago

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )
github-actions[bot] commented 1 week ago

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.92% ( 1243 / 1430 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.77% ( 1055 / 1202 )
Branches: 72.73% ( 64 / 88 )
github-actions[bot] commented 1 week ago

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.45% ( 5642 / 8490 )
Methods: 63.9% ( 692 / 1083 )
Lines: 70.48% ( 4445 / 6307 )
Branches: 45.91% ( 505 / 1100 )