bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 14 forks source link

#3789 - PIR: Program Name and Program Description Bug #3944

Closed sh16011993 closed 6 days ago

sh16011993 commented 1 week ago

As a part of this PR, the bug for the PIR where the Program Name and the Program Description are not showing up once the application is submitted is fixed.

Fix: The bug was happening because both the fields (Name and Description) were having a conditional set as below:

"conditional": {
  "show": true,
  "when": "programnotListed",
  "eq": "true"
},

Removed the above piece of code for both the program name and program description for all the program years.

The problem is that programnotListed never has the value true. It is a Select Boxes Component rather than the Checkbox Component which gets the value programnotListed. We do not need to rely on this component because both the components Program Name and Program Description are wrapped inside a container component that has a conditional setup on it.

Tested the above for the below scenarios:

1. Program is not listed

image

2. Study is not listed

image
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 1 week ago

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.19% ( 3720 / 16761 )
Methods: 10.28% ( 214 / 2081 )
Lines: 25.54% ( 3228 / 12638 )
Branches: 13.61% ( 278 / 2042 )
github-actions[bot] commented 1 week ago

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )
github-actions[bot] commented 1 week ago

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.91% ( 5777 / 8634 )
Methods: 64.65% ( 715 / 1106 )
Lines: 70.85% ( 4537 / 6404 )
Branches: 46.71% ( 525 / 1124 )
github-actions[bot] commented 1 week ago

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.92% ( 1243 / 1430 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.77% ( 1055 / 1202 )
Branches: 72.73% ( 64 / 88 )