bcgov / SIMS

Student Information Management System. Post-Secondary Student Financial Aid System
Apache License 2.0
25 stars 14 forks source link

#3920 - Update Expected Name for Disbursement File #3963

Closed lewischen-aot closed 2 days ago

lewischen-aot commented 3 days ago

Screenshot of the Bull Dashboard completed task with the disbursement schedule records not found image

Screenshot of the Bull Dashboard completed task with the disbursement schedule records found image

bidyashish commented 2 days ago

Any sample file name is added in PR? Regex looks fine for filename

Example matches:
DEVEDU.PBC.DIS.ANYTHING.123
DEVEDU.PBC.DIS.TEST.456
lewischen-aot commented 2 days ago

Any sample file name is added in PR? Regex looks fine for filename

Example matches:
DEVEDU.PBC.DIS.ANYTHING.123
DEVEDU.PBC.DIS.TEST.456

Thanks @bidyashish for pointing it out. There is no sample file added to the PR. The file I used to process the disbursement receipts is similar to the file for the federal provincial part time disbursement file, and the content of the file was modified to match existing disbursement schedules in my local database for running sample processes. The file name was changed to "DEDU.PBC.DIS.20241119.001" to match the regex format for this PR, and the screenshots of the Bull Dashboard show the results of process summary. The regex is now using ${this.esdcConfig.environmentCode}EDU\\.PBC\\.DIS.[0-9]{8}\\.[0-9]{3}$ as a precise match as of @andrewsignori-aot 's comment.

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 2 days ago

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.1% ( 3718 / 16821 )
Methods: 10.19% ( 214 / 2100 )
Lines: 25.44% ( 3226 / 12680 )
Branches: 13.62% ( 278 / 2041 )
github-actions[bot] commented 2 days ago

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )
github-actions[bot] commented 2 days ago

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.93% ( 1244 / 1431 )
Methods: 88.57% ( 124 / 140 )
Lines: 87.78% ( 1056 / 1203 )
Branches: 72.73% ( 64 / 88 )
github-actions[bot] commented 2 days ago

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.96% ( 5773 / 8621 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.89% ( 4530 / 6390 )
Branches: 46.75% ( 525 / 1123 )