search

bcgov / SSGBM-VRI-BEM

This repository is for a Python to R script conversion for the VRI-BEM (vegetation Resource Inventory & Broad Ecosystem Mapping) component of wildlife models
https://bcgov.github.io/SSGBM-VRI-BEM/
Apache License 2.0
3 stars 6 forks source link

BEM correction Large Lake vs Landing #24

Open FrankBornais opened 2 years ago

FrankBornais commented 2 years ago

Just a quick check that both sections below meant to assign BEUMC_S1 to LL in the BEM corrections?

1) Large lake : BCLCS_LEVEL_1 = 'N' AND BCLCS_LEVEL_5 = 'LA' AND Area_Ha >60 ha 2) Landing: BCLCS_LEVEL_5 = 'LL'

ref: https://github.com/bcgov/SSGBM-VRI-BEM/blob/a930c9dd9d3afd70aaaa08122b4e2e7ff52a22ca/Python_Scripts/01b_Step1_BEM_Corrections_BEC_Combo_Check_CSV_Output_v1.7.py#L299:L309

https://github.com/bcgov/SSGBM-VRI-BEM/blob/a930c9dd9d3afd70aaaa08122b4e2e7ff52a22ca/Python_Scripts/01b_Step1_BEM_Corrections_BEC_Combo_Check_CSV_Output_v1.7.py#L505:L510

There is no rush on this. I just wanted to raise a flag since those 2 conditions could have been combined into a single condition and it brought me to have some doubts on wether we really wanted to assign the LL value to both.

Jake-Bradshaw commented 2 years ago

Great catch. That is an error.

The codes are a bit confusing here... a landing (where logs are loaded onto a truck) is coded LL and the lakes are coded LA. We can't use w[cf.index("BEUMC_S1")] = "LL" for both of those.

We need to follow-up on this. @Karine-Pigeon

LL = Landing A compacted area adjacent to a road used for sorting and loading logs.

LA = Lake A naturally occurring static body of water more than two metres deep in some portion. The boundary for the lake is the natural high water mark.

page 15 https://www2.gov.bc.ca/assets/gov/farming-natural-resources-and-industry/forestry/stewardship/forest-analysis-inventory/data-management/standards/vegcomp_poly_rank1_data_dictionaryv5_2019.pdf